Open
Conversation
sfan5
reviewed
Jan 9, 2026
| m_content_features[id] = def; | ||
|
|
||
| #if CHECK_CLIENT_BUILD() | ||
| // Fix copy |
Member
There was a problem hiding this comment.
I'm thinking def.visuals should rather be guaranteed nullptr when set() is called.
and the test code should be re-worked to work like the real code (set everything first, update visuals afterwards)
cx384
added
the
Action / change needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a use after return, when using the
MockGameDef.It's not a beautiful solution, but I suppose we don't want to define any copy (or move) constructors for the content features struct, and we want to keep the visuals pointer inside the content features and reverse.
To do
Ready for Review.
How to test
Compile with address sanitizers
Execute unittests