Skip to content

Formspec: Measure length of PasswordChar in pwdfield[] to avoid scrolling early #16847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CrazyladMT wants to merge 2 commits into
base: master
Choose a base branch
from
+21 −22
Open

Formspec: Measure length of PasswordChar in pwdfield[] to avoid scrolling early #16847

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35c20c2
measure length of PasswordChar instead of user input characters in `p…
CrazyladMT Jan 15, 2026
291246d
move logic
CrazyladMT Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions irr/src/CGUIEditBox.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1469,9 +1469,26 @@ void CGUIEditBox::calculateScrollPos()
u32 cursorWidth = font->getDimension(CursorChar.c_str()).Width;
core::stringw *txtLine = hasBrokenText ? &BrokenText[cursLine] : &Text;
s32 cPos = hasBrokenText ? CursorPos - BrokenTextPositions[cursLine] : CursorPos; // column
s32 cStart = font->getDimension(txtLine->subString(0, cPos).c_str()).Width; // pixels from text-start

// Build the visible line used for width calculations
core::stringw visibleLine;
if (PasswordBox) {

// In password mode, width must be based on whatever PasswordChar is,
// rather than the actual characters input by the user.
visibleLine = core::stringw();
visibleLine.reserve(txtLine->size());
for (u32 i = 0; i < txtLine->size(); ++i) {
visibleLine += PasswordChar;
}
} else {
visibleLine = *txtLine;
}

// Now use visibleLine for width calculations
s32 cStart = font->getDimension(visibleLine.subString(0, cPos).c_str()).Width; // pixels from text-start
s32 cEnd = cStart + cursorWidth;
s32 txtWidth = font->getDimension(txtLine->c_str()).Width;
s32 txtWidth = font->getDimension(visibleLine.c_str()).Width;

if (txtWidth < FrameRect.getWidth()) {
// TODO: Needs a clean left and right gap removal depending on HAlign, similar to vertical scrolling tests for top/bottom.
Expand Down
Loading