Improve OWM API robustness: timeouts and response validation #470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JsonParser accessed response properties like \$uvValue->value and \$temperatureValue->main->temp without checking their existence. If the API changes its response format, this would cause an uncaught property access error. Now throws a clear RuntimeException instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
HTTP requests to OpenWeatherMap had no explicit timeout, so they could hang indefinitely and block PHP processes. Add a 10-second timeout to both UV index and temperature queries. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
JsonParserbefore accessing propertiesProblem
JsonParseraccessed response properties ($uvValue->value,$temperatureValue->main->temp) without checking they exist — if the API changes format, this crashes with an unclear property access errorTest plan
AdhocDataRetrievercatch from PR Add error handling to AdhocDataRetriever #462 covers the display path)🤖 Generated with Claude Code