instance: accept ready as valid running state#392
Merged
Conversation
Member
|
@jasisk can you edit the commit message to include the Signed-off-by line? |
5856193 to
b329a6c
Compare
Contributor
Author
@stgraber oops, sorry. Forgot to sign and sign-off. Done. |
Member
|
@jasisk could you please follow the commit message guideline from CONTRIBUTION.md? |
b329a6c to
a36b6ac
Compare
ready as valid running stateready as valid running state
Contributor
Author
@maveonair I added the resource type prefix. Is the rest of the message good? |
Member
|
@jasisk a quick rebase would let the tests all clear now that the other PR has landed |
Signed-off-by: Jean-Charles Sisk <jasisk@gmail.com>
a36b6ac to
e197bc1
Compare
Member
|
I'll let @maveonair check for the commit message and otherwise we should be good to go, thanks! |
maveonair
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did a little archeology and it seems like this was just a tiny tiny oversight when the helper functions were introduced.
Compiled and tested against the testcase in #391:
Calling out there's one more instance where the helper isn't used but I didn't update it since it bails out early. Guess it's still possible this could bork if it goes to "ready" quickly enough so I'm happy to if you'd rather!
Fixes #391