Skip to content

instance: accept ready as valid running state#392

Merged
maveonair merged 1 commit intolxc:mainfrom
jasisk:js/fix/ready-as-valid-running-state
Feb 13, 2026
Merged

instance: accept ready as valid running state#392
maveonair merged 1 commit intolxc:mainfrom
jasisk:js/fix/ready-as-valid-running-state

Conversation

@jasisk
Copy link
Contributor

@jasisk jasisk commented Feb 12, 2026

Did a little archeology and it seems like this was just a tiny tiny oversight when the helper functions were introduced.

Compiled and tested against the testcase in #391:

incus_instance.testcase: Creating...
incus_instance.testcase: Creation complete after 8s [name=testcase]

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.

Calling out there's one more instance where the helper isn't used but I didn't update it since it bails out early. Guess it's still possible this could bork if it goes to "ready" quickly enough so I'm happy to if you'd rather!

Fixes #391

@stgraber
Copy link
Member

@jasisk can you edit the commit message to include the Signed-off-by line?

@jasisk jasisk force-pushed the js/fix/ready-as-valid-running-state branch 2 times, most recently from 5856193 to b329a6c Compare February 12, 2026 02:33
@jasisk
Copy link
Contributor Author

jasisk commented Feb 12, 2026

can you edit the commit message to include the Signed-off-by line?

@stgraber oops, sorry. Forgot to sign and sign-off. Done.

@maveonair
Copy link
Member

maveonair commented Feb 12, 2026

@jasisk could you please follow the commit message guideline from CONTRIBUTION.md?

@jasisk jasisk force-pushed the js/fix/ready-as-valid-running-state branch from b329a6c to a36b6ac Compare February 12, 2026 14:03
@jasisk jasisk changed the title fix: accept ready as valid running state instance: accept ready as valid running state Feb 12, 2026
@jasisk
Copy link
Contributor Author

jasisk commented Feb 12, 2026

could you please follow the commit message guideline from CONTRIBUTION.md?

@maveonair I added the resource type prefix. Is the rest of the message good?
What do you think about the other usage of the hardcoded "Running" mentioned in the PR body?

@stgraber
Copy link
Member

@jasisk a quick rebase would let the tests all clear now that the other PR has landed

Signed-off-by: Jean-Charles Sisk <jasisk@gmail.com>
@jasisk jasisk force-pushed the js/fix/ready-as-valid-running-state branch from a36b6ac to e197bc1 Compare February 13, 2026 03:40
@stgraber
Copy link
Member

I'll let @maveonair check for the commit message and otherwise we should be good to go, thanks!

Copy link
Member

@maveonair maveonair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasisk Thanks a lot!

@maveonair maveonair merged commit 2d640f7 into lxc:main Feb 13, 2026
10 checks passed
@jasisk jasisk deleted the js/fix/ready-as-valid-running-state branch February 13, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

changing instance state to "ready" results in a failed apply

3 participants

Comments