Skip to content

Fix for DeviseTokenAuth.change_headers_on_each_request being ignored #1525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
juddmon wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix for DeviseTokenAuth.change_headers_on_each_request being ignored #1525

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b66e8d7
Fixing bug where new token could be created after request even when c…
comradeHac May 26, 2021
7877618
Merge pull request #1 from lynndylanhurley/master
juddmon Feb 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/controllers/devise_token_auth/concerns/set_user_by_token.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,11 +100,13 @@ def update_auth_header
# Generate new client with existing authentication
@token.client = nil unless @used_auth_by_token

if @used_auth_by_token && !DeviseTokenAuth.change_headers_on_each_request
if !DeviseTokenAuth.change_headers_on_each_request
# should not append auth header if @resource related token was
# cleared by sign out in the meantime
return if @resource.reload.tokens[@token.client].nil?

return if !@used_auth_by_token

auth_header = @resource.build_auth_header(@token.token, @token.client)

# update the response header
Expand Down