Add new unit test for type checking logic#590
Open
markdouthwaite wants to merge 6 commits intolyst:masterfrom
Open
Add new unit test for type checking logic#590markdouthwaite wants to merge 6 commits intolyst:masterfrom
markdouthwaite wants to merge 6 commits intolyst:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey again!
In response @maciejkula's request on #588 I've added a test to check all combinations of valid input types for
user_idsanditem_ids(i.e.tuple,list,ndarray) pass successfully.To do this, I've added a
conftest.pyfile that includes some handy fixtures for the newtest_predict_user_item_inputs_with_valid_typestest.As an aside, I think some of these fixtures might be useful in other tests (not addressed in this PR) too. I'd be happy to look into how existing tests could be streamlined if that would be useful?