Skip to content

Revert "Saving websocket RTT samples"#233

Merged
bassosimone merged 1 commit intomasterfrom
revert-232-l7-ping
Jan 20, 2020
Merged

Revert "Saving websocket RTT samples"#233
bassosimone merged 1 commit intomasterfrom
revert-232-l7-ping

Conversation

@bassosimone
Copy link
Contributor

@bassosimone bassosimone commented Jan 20, 2020

Reverts #232.

I didn't mean to merge it already 🤦‍♀


This change is Reviewable

@bassosimone bassosimone merged commit 2f6a993 into master Jan 20, 2020
@bassosimone bassosimone deleted the revert-232-l7-ping branch January 20, 2020 13:53
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 1110

  • 47 of 54 (87.04%) changed or added relevant lines in 8 files are covered.
  • 11 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.08%) to 79.295%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ndt7/receiver/receiver.go 13 14 92.86%
ndt7/upload/sender/sender.go 10 16 62.5%
Files with Coverage Reduction New Missed Lines %
ndt7/receiver/receiver.go 1 75.0%
ndt5/protocol/protocol.go 2 83.78%
ndt5/web100/web100_linux.go 2 94.52%
ndt5/c2s/c2s.go 6 73.21%
Totals Coverage Status
Change from base Build 1108: 0.08%
Covered Lines: 1574
Relevant Lines: 1985

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants