Set "numBytes" attribute from the ClientResponse class to Long instead of Double#18
Open
ignaciograsso wants to merge 1 commit intom-lab:mainfrom
Open
Set "numBytes" attribute from the ClientResponse class to Long instead of Double#18ignaciograsso wants to merge 1 commit intom-lab:mainfrom
ignaciograsso wants to merge 1 commit intom-lab:mainfrom
Conversation
…changed to Long. numBytes in ClientResponse.kt changed to Long.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets the numBytes attribute of the ClientResponse class to be a Long.
Being treated as a Double was causing incompatibility problems with other NDT7 clients and the server. In addition, in the other developed clients, as well as in the server, this attribute is treated as an int64.
This change is