Skip to content

Check default value type of Parameter#405

Open
kitagry wants to merge 1 commit intomasterfrom
check-default-type
Open

Check default value type of Parameter#405
kitagry wants to merge 1 commit intomasterfrom
check-default-type

Conversation

@kitagry
Copy link
Member

@kitagry kitagry commented Oct 27, 2024 •
edited
Loading

Check default value of parameter.

import luigi
import gokart
class MyTask(gokart.TaskOnKart):
    foo = luigi.IntParameter(default='s')  # Incompatible default for argument "foo" (default has type "str", argument has type "int")

hiro-o918
hiro-o918 approved these changes Oct 27, 2024
View reviewed changes
test/test_mypy.py
FOO = enum.auto()

class MyTask(gokart.TaskOnKart):
# NOTE: mypy shows attr-defined error for the following lines, so we need to ignore it.
Copy link
Contributor

@hiro-o918 hiro-o918 Oct 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hiro-o918
Copy link
Contributor

hiro-o918 commented Oct 27, 2024

LGTM!!!!!

@hiro-o918
Copy link
Contributor

hiro-o918 commented Oct 27, 2024

Oh, CI failed 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hiro-o918 hiro-o918 hiro-o918 approved these changes

@hirosassa hirosassa Awaiting requested review from hirosassa hirosassa is a code owner

@yokomotod yokomotod Awaiting requested review from yokomotod yokomotod is a code owner

@Hi-king Hi-king Awaiting requested review from Hi-king Hi-king is a code owner

@ujiuji1259 ujiuji1259 Awaiting requested review from ujiuji1259 ujiuji1259 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kitagry @hiro-o918