Skip to content

Test on Python 3.14 release candidate 3#277

Merged
efa2d19 merged 1 commit intomac-cleanup:mainfrom
cclauss:patch-1
Oct 4, 2025
Merged

Test on Python 3.14 release candidate 3#277
efa2d19 merged 1 commit intomac-cleanup:mainfrom
cclauss:patch-1

Conversation

@cclauss
Copy link
Contributor

@cclauss cclauss commented Sep 12, 2025

Test on Python 3.14 release candidate 3

Example

Fixes #[Issue Number]

Description

Briefly describe the changes in this pull request.

  • [Summary of major changes]
  • [Summary of minor changes]
  • [Any other relevant information]

I think this actually works, but I find poetry's messages to be indecipherable.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have used Conventional Commits for my commit messages
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots

Attach screenshots or screen recordings of the changes, if any.

Additional Context

Add any other context or information about the pull request here.

@cclauss cclauss force-pushed the patch-1 branch 5 times, most recently from 624a62f to 727f46e Compare September 12, 2025 17:15
@cclauss cclauss changed the title Test on Python 3.14 release candidate 2 and on macOS 26 Test on Python 3.14 release candidate 2 Sep 12, 2025
@cclauss
Copy link
Contributor Author

cclauss commented Sep 13, 2025

@leycec, your review, please, on the failing test?

@efa2d19
Copy link
Member

efa2d19 commented Sep 13, 2025

tests fail w/ beartype errors, maybe the latest minor cause the problems, try w/ the prev one

@cclauss
Copy link
Contributor Author

cclauss commented Sep 13, 2025

I would not have tried to upgrade beartype if it had succeeded but it did not...
https://github.com/mac-cleanup/mac-cleanup-py/actions/runs/17681246199/job/50255735335#step:5:1120

@leycec
Copy link

leycec commented Sep 14, 2025

Thanks so much for pinging me onboard, @cclauss. First, allow me to uselessly apologize for @beartype failing you here. Second, allow me to uselessly admit I can't replicate this issue locally on my end. This is a shared tragedy. 2025 do be like that.

The following minimal-length example succeeds for me:

from beartype import beartype
from pathlib import Path

@beartype
def check_exists(path: Path | str, *, expand_user: bool = True) -> bool:
    pass

Notably, the problematic Path | str that appears to be failing for you succeeds for me. I have no deep insights. My emoji cat is crying. 😿

How About This...

@beartype 0.22.0rc0 (i.e., release candidate 0) officially lands this Wednesday. If you wouldn't mind holding back on this PR for just a few days, perhaps we could reconvene on Thursday. At that point, I'll kindly request that you bump your mandatory @beartype requirement in pyproject.toml to resemble:

beartype = ">=0.22.0rc0"

Does this seem like a reasonable action plan? If not, emoji cat cries again. 😿 😹

@cclauss
Copy link
Contributor Author

cclauss commented Oct 4, 2025

@ leycec Thanks for jumping in! https://pypi.org/project/beartype --> v0.22.2 gets us to ✅

Congrats on the beartype v0.22.2 release and getting TideLift backing!!

@cclauss cclauss changed the title Test on Python 3.14 release candidate 2 Test on Python 3.14 release candidate 3 Oct 4, 2025
@leycec
Copy link

leycec commented Oct 4, 2025

Aww! Thanks so much for all the kind words. Everyone's so nice at this project. I can't wait to run the newest version of mac-cleanup-py on my wife's now-venerable M1, too... That thing's getting a lil' clunky. Autumn cleaning, your time has come. 😁

@efa2d19 efa2d19 merged commit ba4d6ef into mac-cleanup:main Oct 4, 2025
11 checks passed
@cclauss cclauss deleted the patch-1 branch October 4, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants