Feature/wmbus #71
Merged
Feature/wmbus #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maebli
force-pushed
the
feature/wmbus
branch
6 times, most recently
from
96f02a0 to
8e2db6c
Compare
Crate restructuring Split wired M-Bus link layer into separate crate Introduced m-bus-core crate for shared functionality Refactored both wired and wireless implementations to use core library Wireless M-Bus support Added wireless frame parsing with incremental test coverage Renamed frame types to distinguish wired vs wireless variants Integrated wireless module into main library exports Parsing improvements Added manufacturer code extraction Refactored "medium" to "device type" with complete type coverage Proper function field parsing CRC validation (removed frame types A/B as CRC pre-stripped) Fixed CI field offset handling Security & decryption Renamed "signature" to "configuration_field" Added security mode parsing Implemented decryption with static key provider Added Mode 5 decryption support Validated against wmbusmeters test vectors Cleanup & docs Added "short TPL" header support Improved README and documentation Added CLI examples Removed dead code and suppressed warnings fixing clippy refactoring location of decryption crate
…ifying different frame types
maebli
force-pushed
the
feature/wmbus
branch
from
f639b55 to
06bdcfe
Compare
maebli
force-pushed
the
feature/wmbus
branch
from
7aa30d7 to
4ba970e
Compare
maebli
force-pushed
the
feature/wmbus
branch
from
4ba970e to
ee00c14
Compare
Collaborator
SarthakSingh31
left a comment
SarthakSingh31
left a comment
There was a problem hiding this comment.
Left comments about some common issues.
Serde does have a no_std mode https://serde.rs/no-std.html but since the Cargo.toml does not disable std for serde, serde everywhere should imply std.
maebli
force-pushed
the
feature/wmbus
branch
4 times, most recently
from
0c62d27 to
f6dd808
Compare
Replace 56 todo!() panics with proper Unimplemented errors, consolidate duplicated code in m-bus-core, and document supported features in README.
maebli
force-pushed
the
feature/wmbus
branch
from
275335a to
b36d60e
Compare
maebli
force-pushed
the
feature/wmbus
branch
from
b36d60e to
5d6abb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing wireless mbus feature #65