Conversation
Add release action Add pre-commit configuration
maekind
force-pushed
the
feature/Create_branching_validation
branch
from
94a8dad to
9a50e92
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2 +/- ##
==========================================
+ Coverage 89.79% 92.75% +2.95%
==========================================
Files 6 6
Lines 98 138 +40
==========================================
+ Hits 88 128 +40
Misses 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
src/pylembic/cli.py
Outdated
| False, "--verbose", help="Show migrations validation logs." | ||
| ), | ||
| detect_branches: bool = typer.Option( | ||
| False, "--detect-branches", help="Include branching in the validation." |
There was a problem hiding this comment.
I'd suggest to improve a bit the help. You are stating that the includes the branching, but not that fails when branches are found
There was a problem hiding this comment.
I have enriched the message explaining that validation will fail if branches are found.
| str: The formatted log message | ||
| """ | ||
| base_fmt = base_fmt or "%(levelname)s\t %(asctime)s | %(message)s | " | ||
| dynamic_fields = "".join([f"%({field})s" for field in fields]) |
There was a problem hiding this comment.
Wouldn't be better to join with a blank space?
dynamic_fields = " ".join([f"%({field})s" for field in fields])Or maybe this is already doing this, just asking/guessing...
There was a problem hiding this comment.
In one logging line there will only be one of the fields. So, it’s better to not have spaces in between so we will have weird formatted lines.
There was a problem hiding this comment.
ok, so dynamic_fields will contain only one field to be serialized in the logs?
maekind
force-pushed
the
feature/Create_branching_validation
branch
from
b1e8932 to
4495220
Compare
maekind
force-pushed
the
feature/Create_branching_validation
branch
from
3a6f6b0 to
ee40bb6
Compare
2 participants
uv.