Merged
Conversation
…ove default value handling and remove unused code
…dling - Added a renderSubmitButton prop to DynamicForm for custom submit button rendering. - Updated ComboBox component to handle label mismatches and added overrideOnMismatchLabel prop for better label management. - Removed console log statements across various components for cleaner code. - Commented out unused validation configurations in the ComprehensiveForm for clarity.
- Added support for required validation in the ComboBox component. - Updated InputLabel to reflect the required status based on fieldConfig validation.
… for custom error handling - Introduced renderErrorMessage prop in FieldConfig and FormContentProps to allow custom error message rendering. - Updated InputRenderer to utilize the new renderErrorMessage prop for improved error display.
…endering - Removed the renderErrorMessage prop from InputRenderer. - Updated error message handling to utilize fieldConfig.renderErrorMessage for improved customization and consistency in error display.
…ce DynamicForm error handling - Bumped the version of @matthew.ngo/react-form-kit from 0.0.8 to 0.0.10 in package.json and yarn.lock. - Integrated InputErrorMessage component from @matthew.ngo/react-form-kit into DynamicForm for improved error message rendering. - Updated the BasicInputTypes story to utilize a custom input component and enhanced error validation logic.
Enables the combobox to render options as disabled, based on the `disabled` property provided in the item object. Updates storybook examples to demonstrate the functionality. Increments package version.
Adds a `draggableListDirection` prop to the ComboBox component, allowing users to control the direction of the draggable list (vertical or horizontal). This improves the flexibility of the ComboBox component.
Updates the `@matthew.ngo/react-form-kit` dependency to the latest version.
Introduces a new `loadInitialItems` prop to the ComboBox component. This prop allows developers to control whether initial items are loaded when the component mounts. It provides flexibility in scenarios where initial data loading is not always required, potentially improving performance and user experience. The component now loads initial items based on either the presence of default values or the new `loadInitialItems` prop.
Ensures the ComboBox component reinitializes its data when certain props change. This resolves an issue where the component would not reflect updated default values or search API configurations after the initial load. It now properly reacts to changes in `searchApi`, `transformResponse`, `loadInitialItems`, `fieldConfig.defaultValue`, and `overrideOnMismatchLabel`.
Improves the ComboBox component by refactoring the data initialization and search functionalities. The component now uses `useCallback` and `useMemo` hooks to optimize performance and prevent unnecessary re-renders. It enhances the handling of default values, especially when there are label mismatches between the default values and the values from the search API. Also improves initial data loading to handle cases where default values require additional data fetching.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.