feat(dotted-map) : Add marker overlay support to DottedMap#862
Open
Yeom-JinHo wants to merge 4 commits intomagicuidesign:mainfrom
Open
feat(dotted-map) : Add marker overlay support to DottedMap#862Yeom-JinHo wants to merge 4 commits intomagicuidesign:mainfrom
Yeom-JinHo wants to merge 4 commits intomagicuidesign:mainfrom
Conversation
|
@Yeom-JinHo is attempting to deploy a commit to the product-studio Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
@dillionverma While integrating it, I realized that having an overlay option would be really helpful for cases like displaying countries (e.g., flags/labels) on top of markers, so I added this feature. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an optional overlay rendering API to
DottedMapso consumers can render custom marker overlays (e.g., image/label badges) on top of the existing marker circles while keeping the current behavior as-is.Changes
DottedMapProps/DottedMapto supportmarkers?: M[]withM extends Markerand a default type parameter (M = Marker).renderMarkerOverlay?: (args) => ReactNodeto render custom SVG overlay content using projected coordinates (x,y) and radius (r).MapMarker<M> = M & { x: number; y: number }for projected markers returned fromaddMarkers.Motivation
Breaking Changes
renderMarkerOverlayis optional.Screenshots