Conversation
|
Also corrected bug http://leetcode.net/mantis/view.php?id=104 |
|
Is it OK to use AlterColumnSQL as opposed to the date_migrate function we've been using elsewhere in MantisBT? For the alternative approach, see my earlier patch at http://git.mantisforge.org/w/timecard/dhx.git?a=blobdiff;f=Timecard/Timecard.php;fp=Timecard/Timecard.php;h=61634b6ab1d4b70cd7c34705a118c70cc7d05f64;hp=599ab53d2c36b60bef15cc8f3cd28db5680accb0;hb=8a9faa287260460044e4bb9f6c0ec0a772ae2408;hpb=fa0e403314f5379f5d952d2f2bebe7e22d10f355 |
|
This patch also seems to require the user to specify (and read) minutes as float values (3.5 hours = 3 hours 30 minutes, 0.25 hours = 15 minutes) which seems confusing. My patch from 2 years ago at http://git.mantisforge.org/w/timecard/dhx.git?a=commitdiff;h=93c6829f48b62aace54d79ad1a81b7e507ff8d7d (there are other related patches in that branch too) used "hh:mm" notation which is the same as what the inbuilt MantisBT time tracking feature uses. I think the reason these patches weren't merged 2 years ago is that John didn't like the idea of allowing fractional hours to be tracked (too precise). Therefore the patch mentioned above allows the administrator to toggle the precision between hours and minutes. These old patches would need some work to bring them up to a standard ready to commit to the current Timecard plugin (and some changes to make the plugin work with the 'master' branch). However I think they serve as a good reference when creating a new/updated patch to handle minute resolutions. |
|
Yes, your right, perhaps it is a bit confiusing. I did it this way because where i work we use other systems this way. We need it in the same way. |
2 participants
No description provided.