Open
Conversation
Owner
|
Thanks for helping out! I haven't tested the code yet but there seems to be a bug with the btc- pairs, we don't need those pairs and it's just going to overwrite the original coins. For example LTC-BTC has the correct price for LTC in BTC. But BTC-LTC will overwrite that with another number which we don't need. |
Owner
|
Can you remove the BTC- block so I can squash and merge? |
Owner
|
Get on the slack for this project, Join my Slack team! https://join.slack.com/t/cc-a/shared_invite/MjE2NTQyNzM0NjYwLTE1MDA4MjA5MzEtMjhlNjZmYzJkYg |
added 8 commits
July 24, 2017 01:08
…iew for single highes spread
Owner
|
What's the best way to go through all the changes? I'll take at code look from your last commit and see if everything is fine |
albandaft
reviewed
Sep 16, 2017
| link: 'https://c-cex.com/', | ||
| pairURL : '', | ||
| last: function (data, coin_prices) { | ||
| return new Promise(function (res, rej) { |
There was a problem hiding this comment.
why we need Promise in this function?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added c-cex exchange. There's no test to test if it work, but it lists on localhost:3000, but I think there could be some errors in price calculation