This repository was archived by the owner on Aug 8, 2023. It is now read-only.
Tiles LOD: load and render based on zoom when displayed#15230
Draft
Tiles LOD: load and render based on zoom when displayed#15230
Conversation
b21b82c to
bd3f137
Compare
1ec5
reviewed
Jul 29, 2019
| * center of the screen, max pitch is further capped by Transform::getMaxPitchForEdgeInsets. | ||
| * We set the max to 70 to keep the limit constant with small padding. | ||
| */ | ||
| constexpr double PITCH_MAX = 70 * DEG2RAD; |
Contributor
There was a problem hiding this comment.
FYI, the iOS map SDK is currently using this constant to fake a tilted annotation view specifically for the user dot / user puck:
mapbox-gl-native/platform/ios/src/MGLAnnotationView.mm
Lines 162 to 165 in b6dd995
Though something like mapbox/ios-sdk-examples#111 (comment) would be a much sounder approach long-term: #10498.
bd3f137 to
f37d81d
Compare
Unit test verifies that, with different camera parameters combinations LOD tile cover covers all tiles returned by single level tileCover.
Contributor
Author
|
Update: |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attached video shows 70 degree pitch on iPadMini2: ipadmini270degpitch.mp4.zip
Fixes #9037, #15163