Add array type for storing coordinate values to allow improving accuracy for small radius#244
Open
ewelinaBS wants to merge 1 commit intomapbox:mainfrom
Open
Add array type for storing coordinate values to allow improving accuracy for small radius#244ewelinaBS wants to merge 1 commit intomapbox:mainfrom
ewelinaBS wants to merge 1 commit intomapbox:mainfrom
Conversation
…acy for small radius
This was referenced Aug 14, 2024
Contributor
|
I've added a unit test for this in #249 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For small radius <~50cm, the clustering is not accurate. (Probably the accuracy will be different depending on the latitude.) The problem originates from rounding the coordinates to float32.
Work done
Enable arrayType argument for supercluster constructor to determine in what format store the coordinates values.
Default
Float32Arrayvalue will work the same as before.