Skip to content

Add BottomNav#541

Merged
birkskyum merged 13 commits intomainfrom
Add-BottomNav
Feb 11, 2026
Merged

Add BottomNav#541
birkskyum merged 13 commits intomainfrom
Add-BottomNav

Conversation

@birkskyum
Copy link
Member

@birkskyum birkskyum commented Feb 11, 2026

Chunking the improvements in #535 up into smaller pieces that we can review separately.

This adds a Bottom Navigation to the current site, without changing anything else on the page.

After:
Screenshot 2026-02-11 at 18 49 14

Before:
Screenshot 2026-02-11 at 18 41 21

@CommanderStorm
Copy link
Member

Content LGTM.

Alignment wise, I think this is a bit too right-heavy -> more symetric would work better

image

@birkskyum
Copy link
Member Author

birkskyum commented Feb 11, 2026

@CommanderStorm Not sure i understand. I've centered it a bit - looks like this now on large screens. Is that what you meant, or did you want the two right most columns swapped? Instead of me guessing, can you do the style-change you'd like to see?

Screenshot 2026-02-11 at 19 01 46

@CommanderStorm
Copy link
Member

I pushed a change, it is a bit ugly, but likely what we want.

Could you have a look if this is too ugly of a hack?

@birkskyum
Copy link
Member Author

birkskyum commented Feb 11, 2026

I think i'm in favor of the initial style here that Bart submitted. Not very common to have right aligned content.

Remember, with a potential split of About, we might find entries enough for a fourth column (like adding a Branding assets link etc)

@birkskyum birkskyum requested a review from louwers February 11, 2026 20:02
@birkskyum
Copy link
Member Author

How about this - I added a brand asset header id so the link goes to the right place on the About page

Screenshot 2026-02-11 at 21 35 59

Copy link
Member

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about a compromise:

  • gutters between the rows when stacked, so that they are not entirely on top of each other
  • only 2 instead of 4 rows on sm + md
  • text-center, so it does not look off-center

@birkskyum birkskyum merged commit 8894b97 into main Feb 11, 2026
1 check passed
@birkskyum birkskyum deleted the Add-BottomNav branch February 11, 2026 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants