RD-1544 Tests for intersections #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katemihalikova
approved these changes
Feb 7, 2026
src/Item3D.ts
Outdated
| // we need to make sure hte matrices are up to date | ||
| // for the OBB, AABB or sphere calcs. | ||
| this.parentLayer.updateItemMatrices(); | ||
| // this.parentLayer.updateItemMatrices(); |
Collaborator
Author
There was a problem hiding this comment.
can get removed entirely as this happens on every render anyway.
Collaborator
Author
|
/update-snapshots |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Layer3D.removeMeshdid not correctly remove the mesh from the scene.Description
.remove()method toItem3D, including all cleanup logic. Implemented this logic inLayer3D.removeMeshAcceptance
Checklist