Skip to content

Teams webhook fix #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vaaceph wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Teams webhook fix #64

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
730de08
use teams webhook whole url
vaaceph-khan Oct 27, 2021
667cbea
correct documentation
vaaceph-khan Oct 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions mara_pipelines/notification/teams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@


class Teams(ChatNotifier):
def __init__(self, token):
def __init__(self, url):
"""
Pipeline notifications via Microsoft Teams

Args:
token: The id of the notification web hook, e.g. `'1234abcd-1234-abcd-1234-12345abcdef@1234abcd-1234-abcd-1234-abcde12345/IncomingWebhook/12345678abcdefg/123abc-1235-abcd-1234-12345abcdef`
url: The url of the notification web hook
"""
super().__init__()
self.token = token
self.url = url

def send_run_started_interactively_message(self, event: pipeline_events.RunStarted):
text = ('<font size="4">&#x1F423;</font> ' + event.user
Expand Down Expand Up @@ -51,7 +51,7 @@ def send_task_failed_message(self, event: pipeline_events.NodeFinished):
self._send_message({'text': text})

def _send_message(self, message):
response = requests.post(url='https://outlook.office.com/webhook/' + self.token, json=message)
response = requests.post(url=self.url, json=message)

if response.status_code != 200:
raise ValueError(f'Could not send message. Status {response.status_code}, response "{response.text}"')
Expand Down