Improved old Better Visualizer#299
Open
Matter-Shifter wants to merge 6 commits intomarcopixel:masterfrom
Open
Conversation
This feature will be used in variable file to switch between default file and modified file.
With 'switch' feature, this will allow us to change between file(MeasureBandSmoothed[number].inc). This will allows any programmers to add their own customized MeasureBandSmoothed[number].inc file without modifying the default file.
With 'switch' feature, this will allow us to change between files(MeasureBandSmoothed[number].inc). This will allows any programmers to add their own customized MeasureBandSmoothed[number].inc file without modifying the default file.
Added number 0 at the end of file name (default file). The number will be used for switch in variable file.
Number 1 added at the end of file (Custom File marcopixel#1). The number will be used for switch in variable file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems
About 3 years ago, I tried to customized
MeasureBandsSmoothed.inc, but there were issues with performance and CPU usage. Back then, I didn't considered users with slower PC, which kinda disappointing.Solution
This time, I added the 'switch' feature in variable file. I discovered this 'switch' thing about 1-2 years ago, which kinda neat. Without modifying the default
MeasureBandsSmoothedfile (but renaming it toMeasureBandsSmoothed0.inc), 'switch' allows users to switch between the default and the customized file by using number. I added my customized file (MeasureBandsSmoothed1.inc) to give an idea how the 'switch' works.Additional Information
For my 'multipliers' and 'divider' thing, that's only used for my custom
MeasureBandsSmoothedfile.Summary
So the main point here is, for any user who want to use any custom
MeasureBandsSmoothedfile without modifying the default file(even changing the file's extension to .bak), 'switch' is the solution. [I'm sorry if I'm repeating this again]What do you think?