Conversation
🦋 Changeset detectedLatest commit: 42036da The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Coverage Report for Marigold Code Coverage
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
|
Accessibility tests executed. Download the report here. |
|
Accessibility tests executed. Download the report here. |
|
Accessibility tests executed. Download the report here. |
|
Accessibility tests executed. Download the report here. |
|
Accessibility tests executed. Download the report here. |
|
Accessibility tests executed. Download the report here. |
|
Accessibility tests executed. Download the report here. |
|
Accessibility tests executed. Download the report here. |
|
Accessibility tests executed. Download the report here. |
|
Accessibility tests executed. Download the report here. |
|
Accessibility tests executed. Download the report here. |
Description
Migrate from
class-variance-authoritytocva(v1 beta) and simplifyextendThemevia function composition.Key changes:
class-variance-authoritydependency withcvav1 beta, which has built-in Tailwind merge support viadefineConfigcvawrapper inclassName.utils.tsto usecva'sdefineConfigwith atwMergehook,removing ~40 lines of manual type definitions and wrapper code
extendThemeto compose style functions directly (cn(existingFn(props), newFn(props))) instead ofextracting and merging variant configs — this fixes a bug where
defaultVariantsandcompoundVariantswere lostduring merging
theme-docsandtheme-ruito the newcvaAPI (object config withbase/variants/compoundVariantskeys)ConfigSchema,ConfigVariants,ConfigVariantsMulti,Config,Props) that areno longer needed — only
ClassValueandVariantPropsremainTest Instructions:
pnpm buildto verify all packages build successfullypnpm test:unitto verify unit tests passpnpm sband verify components render correctly with their variants in StorybookextendThemeworks correctly —defaultVariantsandcompoundVariantsshould now be preserved whenextending a theme
Reviewers:
@marigold-ui/developer
Pull Request Checklist: