fix: prevent sidebar resize handle from overlapping file explorer buttons #8181
Open
maxkoretskyi wants to merge 3 commits intomarimo-team:mainfrom
Open
fix: prevent sidebar resize handle from overlapping file explorer buttons #8181maxkoretskyi wants to merge 3 commits intomarimo-team:mainfrom
maxkoretskyi wants to merge 3 commits intomarimo-team:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Closes #5920
Description of Changes
The sidebar resize handle's hit area overlapped with the file explorer's three-dot menu button, making it difficult to click "Rename" and other file actions.
Two changes in
frontend/src/components/editor/chrome/wrapper/app-chrome.tsx:Removed
mr-[-4px]negative margin on the sidebar panel body. This margin was pushing the file list content 4px into the resize handle zone, causing the entire handle to sit on top of interactive elements.Reduced
hitAreaMarginsonPanelResizeHandlefrom the library default of{ coarse: 15, fine: 5 }to{ coarse: 15, fine: 2 }. Thefinevalue controls the invisible hit area for mouse pointers — reducing it from 5px to 2px keeps the resize cursor from appearing too far from the actual panel edge. Thecoarsevalue (touch devices) is kept at the default since larger touch targets are needed there.Checklist