openidConnect: Respect the discovered oauth2.AuthStyle in token refresh#610
Open
mrkschan wants to merge 3 commits intomarkbates:masterfrom
Open
openidConnect: Respect the discovered oauth2.AuthStyle in token refresh#610mrkschan wants to merge 3 commits intomarkbates:masterfrom
mrkschan wants to merge 3 commits intomarkbates:masterfrom
Conversation
The `oauth2.TokenSource` would discover the right place to pass the client credentials, i.e. HTTP Authorization header vs HTTP POST form. It is better not to hardcode the use of HTTP POST form.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
oauth2.TokenSourcewould discover the right place to pass the client credentials, i.e. HTTP Authorization header vs HTTP POST form. It is better not to hardcode the use of HTTP POST form.