fix: resolve Go test failures in 2019 and 2024#9
Merged
markkovari merged 2 commits intomainfrom Oct 29, 2025
Merged
Conversation
- Remove unused 'errors' import in 2024/golang/cmd/04.go - Add filepath parameter to readCommands() function in 2019/go/cmd/15 to match test expectations 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Remove unstable feature flag #![feature(drain_filter)] - Replace drain_filter with iter_mut + retain pattern - All Rust tests in 2021 now compile and pass 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
markkovari
added a commit
that referenced
this pull request
Oct 29, 2025
* fix: resolve Go test failures in 2019 and 2024 - Remove unused 'errors' import in 2024/golang/cmd/04.go - Add filepath parameter to readCommands() function in 2019/go/cmd/15 to match test expectations 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * fix: replace deprecated drain_filter with stable alternative in 2021/_4 - Remove unstable feature flag #![feature(drain_filter)] - Replace drain_filter with iter_mut + retain pattern - All Rust tests in 2021 now compile and pass 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: markkovari <kovarimarkofficial@gmail.com>
markkovari
added a commit
that referenced
this pull request
Oct 29, 2025
* fix: resolve Go test failures in 2019 and 2024 (#9) * fix: resolve Go test failures in 2019 and 2024 - Remove unused 'errors' import in 2024/golang/cmd/04.go - Add filepath parameter to readCommands() function in 2019/go/cmd/15 to match test expectations 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * fix: replace deprecated drain_filter with stable alternative in 2021/_4 - Remove unstable feature flag #![feature(drain_filter)] - Replace drain_filter with iter_mut + retain pattern - All Rust tests in 2021 now compile and pass 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: markkovari <kovarimarkofficial@gmail.com> * docs: add README rocket * fix: prevent empty matrix values when no projects change When only non-code files (like README.md) change, the change detection was outputting [""] instead of []. This caused jobs to run with empty matrix values, leading to failures: - cargo test failing with "could not find Cargo.toml" - dotnet restore failing with "no project or solution file" Now properly outputs [] when no projects are detected, preventing jobs from running with empty matrix values. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Signed-off-by: markkovari <kovarimarkofficial@gmail.com> Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
errorsimport in 2024/golang/cmd/04.gofilepathparameter toreadCommands()function in 2019/go/cmd/15 to match test expectationsTest Results
All Go tests now pass:
Changes
2024/golang/cmd/04.go:5- Removed unused import2019/go/cmd/15/main.go:9- Updated function signature to accept filepath parameter🤖 Generated with Claude Code