Disable Admin Password Expiration And Fix Sample Data Upgrade Order#1393
Merged
markshust merged 9 commits intomarkshust:release/nextfrom Feb 9, 2026
Merged
Disable Admin Password Expiration And Fix Sample Data Upgrade Order#1393markshust merged 9 commits intomarkshust:release/nextfrom
markshust merged 9 commits intomarkshust:release/nextfrom
Conversation
PR Summary
|
Removed redundant setup:upgrade command before activating sample data.
Owner
|
I didn't see this PR so already fixed the setup:upgrade issue, however I'll pull in your other change. Thanks for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change disables admin password expiration in the development environment by setting the password lifetime to 0, so admin users are not forced to regularly change their passwords while developing.
It also moves bin/magento setup:upgrade to run immediately after sampledata:deploy. Running the upgrade only at the end cause sample data to not be properly applied and its modules appear as disabled. Running it right after deploying sample data ensures all sample data modules are correctly registered before continuing with the rest of the setup.