deepupdate change recursion to loop#625
Open
lucasfcnunes wants to merge 1 commit intomarshmallow-code:devfrom
Open
deepupdate change recursion to loop#625lucasfcnunes wants to merge 1 commit intomarshmallow-code:devfrom
lucasfcnunes wants to merge 1 commit intomarshmallow-code:devfrom
Conversation
Solves RecursionErrors exceptions/crashes caused by bloated memory use or high recursion depth when calling deepupdate(). *The same issues can occur on copy.deepcopy() calls.
Member
|
Do you have a real life use case where the update process significantly eats up the memory to a point where the app crashes? Or is this more of a theoretical issue? |
Author
|
oh, i did. i was recursively building an api spec using a web scraping engine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves RecursionErrors exceptions/crashes caused by bloated memory use or high recursion depth when calling deepupdate().
*The same issues can occur on copy.deepcopy() calls.