Fix model discovery to respect injected configuration#697
Fix model discovery to respect injected configuration#697
Conversation
|
Warning Rate limit exceeded@matdev83 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 13 minutes and 6 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
llm-interactive-proxy/src/core/app/controllers/models_controller.py
Lines 384 to 387 in 9f3fd5c
When the injected IConfig has no backends attribute, the function constructs a fallback_config = AppConfig() so model discovery can proceed, but the subsequent call to backend_factory.create_backend still passes the original config object. Any stub config without backends will therefore fail inside the factory (which expects an AppConfig) despite the fallback being available, whereas the pre-change code replaced config entirely with AppConfig(). The fallback configuration should be the one handed to the factory in this scenario.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
Testing
Codex Task