Enhance OpenRouter backend for extended parameters#708
Conversation
|
Warning Rate limit exceeded@matdev83 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 23 minutes and 55 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if domain_request.repetition_penalty is not None: | ||
| payload["repetition_penalty"] = domain_request.repetition_penalty |
There was a problem hiding this comment.
Access OpenRouter fields missing from ChatRequest
The new payload section assumes the request model already defines attributes such as repetition_penalty, top_logprobs, min_p, transforms, etc. However ChatRequest/CanonicalChatRequest in src/core/domain/chat.py do not declare these fields and Pydantic ignores unknown keys when copying. As a result a normal call hits domain_request.repetition_penalty here and raises AttributeError, so every OpenRouter chat request crashes before sending the HTTP call. The parameters need to be added to the domain model or accessed via getattr(..., None) to tolerate missing fields.
Useful? React with 👍 / 👎.
Summary
Testing
Codex Task