Skip to content

Update LOBSTER output files list#1044

Merged
esoteric-ephemera merged 20 commits intomaterialsproject:mainfrom
naik-aakash:update_lobster_outputs
Feb 4, 2026
Merged

Update LOBSTER output files list#1044
esoteric-ephemera merged 20 commits intomaterialsproject:mainfrom
naik-aakash:update_lobster_outputs

Conversation

@naik-aakash
Copy link
Contributor

@naik-aakash naik-aakash commented Nov 5, 2024

Changes

With LOBSTER v>=5, There are new keywords added that enables generating new output files for specific types of analysis, ideally they should also get gzipped if user enables such calculations, thus this list of output has been updated

Todo

  • Add test files and update tests

@naik-aakash naik-aakash changed the title update output files list [WIP] Update output files list Nov 5, 2024
@naik-aakash naik-aakash marked this pull request as draft November 5, 2024 16:42
@naik-aakash naik-aakash changed the title [WIP] Update output files list [WIP] Update LOBSTER output files list Nov 5, 2024
@codecov
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.93%. Comparing base (4244da9) to head (47f486d).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1044      +/-   ##
==========================================
+ Coverage   72.82%   76.93%   +4.11%     
==========================================
  Files         187      187              
  Lines       13637    13627      -10     
  Branches     1370     1372       +2     
==========================================
+ Hits         9931    10484     +553     
+ Misses       3161     2592     -569     
- Partials      545      551       +6     
Files with missing lines Coverage Δ
src/atomate2/lobster/files.py 91.66% <ø> (ø)

... and 44 files with indirect coverage changes

@esoteric-ephemera
Copy link
Collaborator

Hey @naik-aakash and @JaGeo is this ready to be merged? Not sure if there's also a bump in the lobsterpy dependence that's needed

@naik-aakash
Copy link
Contributor Author

Hi @esoteric-ephemera , its not yet ready, I will try to add some tests files by end of this week then ping you once am done.

@esoteric-ephemera
Copy link
Collaborator

No rush at all! Trying to clear out older PRs / make sure they don't get stale

@naik-aakash naik-aakash marked this pull request as ready for review February 4, 2026 14:17
@naik-aakash naik-aakash changed the title [WIP] Update LOBSTER output files list Update LOBSTER output files list Feb 4, 2026
@naik-aakash
Copy link
Contributor Author

naik-aakash commented Feb 4, 2026

Hi @esoteric-ephemera , this PR could be merged.

Generating LobsterTaskDoc with with latest lobster version files with new keywords in lobsterin (new test files in this PR) will fail untill materialsproject/pymatgen#4481 this PR in pymatgen is merged and new version is available.

@esoteric-ephemera
Copy link
Collaborator

Thanks @naik-aakash, I'm looking into why unrelated tests are suddenly failing at the networkx stage and will merge once I get that resolved

@esoteric-ephemera esoteric-ephemera merged commit b7e2b95 into materialsproject:main Feb 4, 2026
16 checks passed
@JaGeo
Copy link
Member

JaGeo commented Feb 4, 2026

Oh, @esoteric-ephemera we need to pin jobflow now? Did you see why @esoteric-ephemera ? We might need to discuss this within a joblow issue then.

@JaGeo
Copy link
Member

JaGeo commented Feb 4, 2026

@esoteric-ephemera ah, you already did this. Apologies. My email notifications arrive very late today!

@esoteric-ephemera
Copy link
Collaborator

All good! Should've linked the issue here before:
materialsproject/jobflow#847

Something to do with None values being set when previously they weren't? Not very sure, the issue propagates up through networkx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants