Update LOBSTER output files list#1044
Update LOBSTER output files list#1044esoteric-ephemera merged 20 commits intomaterialsproject:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1044 +/- ##
==========================================
+ Coverage 72.82% 76.93% +4.11%
==========================================
Files 187 187
Lines 13637 13627 -10
Branches 1370 1372 +2
==========================================
+ Hits 9931 10484 +553
+ Misses 3161 2592 -569
- Partials 545 551 +6
|
|
Hey @naik-aakash and @JaGeo is this ready to be merged? Not sure if there's also a bump in the lobsterpy dependence that's needed |
|
Hi @esoteric-ephemera , its not yet ready, I will try to add some tests files by end of this week then ping you once am done. |
|
No rush at all! Trying to clear out older PRs / make sure they don't get stale |
|
Hi @esoteric-ephemera , this PR could be merged. Generating |
|
Thanks @naik-aakash, I'm looking into why unrelated tests are suddenly failing at the networkx stage and will merge once I get that resolved |
|
Oh, @esoteric-ephemera we need to pin jobflow now? Did you see why @esoteric-ephemera ? We might need to discuss this within a joblow issue then. |
|
@esoteric-ephemera ah, you already did this. Apologies. My email notifications arrive very late today! |
|
All good! Should've linked the issue here before: Something to do with |
Changes
With LOBSTER v>=5, There are new keywords added that enables generating new output files for specific types of analysis, ideally they should also get gzipped if user enables such calculations, thus this list of output has been updated
Todo