Fix JSONStore and add MemoryStore option in Installation Docs#1365
Merged
JaGeo merged 2 commits intomaterialsproject:mainfrom Jan 2, 2026
Merged
Fix JSONStore and add MemoryStore option in Installation Docs#1365JaGeo merged 2 commits intomaterialsproject:mainfrom
JaGeo merged 2 commits intomaterialsproject:mainfrom
Conversation
Member
|
@thomasloux Thank you! I kind of forgot that this is still part of the Installation instructions! I think we should suggest the MemoryStore as a default. Actually, it should work without the setup as well. Would you mind changing this as part of this PR? |
Contributor
Author
|
Indeed it works without setting anything (don't provide jobflow.yaml). Do you want MemoryStore as default before MongoStore or just before JSONStore ? |
Member
|
@thomasloux just before JSONStore. MongoStore is still the better option if you want to run high-throughput. We have been working on this as well to provide a different option. |
Member
|
@thomasloux Thanks! If you want to, you can add yourself to the list of contributors in your second PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the installation JSONStore (init requires paths and not uri). Also add MemoryStore in order to quickly test the installation as JSONStore does not work with all workflows (failing with PhononMaker with TypeError: Type is not JSON serializable: ScalarFloat).
Checklist
Work-in-progress pull requests are encouraged, but please put [WIP] in the pull request
title.
Before a pull request can be merged, the following items must be checked:
The easiest way to handle this is to run the following in the correct sequence on
your local machine. Start with running
ruffandruff formaton your new code. This willautomatically reformat your code to PEP8 conventions and fix many linting issues.
Run ruff on your code.
type check your code.
Note that the CI system will run all the above checks. But it will be much more
efficient if you already fix most errors prior to submitting the PR. It is highly
recommended that you use the pre-commit hook provided in the repository. Simply run
pre-commit installand a check will be run prior to allowing commits.