Conversation
jkalias
reviewed
Mar 23, 2023
| throw new ArgumentException("The radius is negative."); | ||
| } | ||
|
|
||
| this.CenterPoint = centerPoint; |
Member
There was a problem hiding this comment.
Please remove all this. qualifiers
Member
There was a problem hiding this comment.
IIRC we use StyleCop with default settings in this repro so if so this. is correct.
Member
There was a problem hiding this comment.
I have already removed all "this." references in a previous commit, and the CI build didn't complain, so I thought it was an acceptable change
| /// <param name="p3">The third point on the sphere</param> | ||
| /// <param name="p4">The last point on the sphere</param> | ||
| public static Sphere3D FromFourPoints(Point3D p1, Point3D p2, Point3D p3, Point3D p4) | ||
| { |
Member
There was a problem hiding this comment.
I would favor an implementation which is easier to follow, based for example on intersections of planes and lines
Member
There was a problem hiding this comment.
I think it would be useful to have additional methods, like
- intersection of sphere with line/ray
- intersection of sphere with plane
- intersection of sphere with another sphere
- functions which check if a point lies inside/on/outside of the circle
| using MathNet.Spatial.Euclidean; | ||
| using NUnit.Framework; | ||
|
|
||
| namespace MathNet.Spatial.UnitTests.Euclidean |
| /// <inheritdoc /> | ||
| [Pure] | ||
| public override int GetHashCode() => HashCode.Combine(this.CenterPoint, this.Radius); | ||
| } |
Member
|
@fcsangminpark any updates on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.