Feat: Line2D.DistanceTo(Point2D p)

[f-frhs]

I implemented Line2D.DistanceTo(Point2D p) which calculates the distance from this line to the given point p.
This method should always return the value of 0 or positive.

It will be nice if we can discuss whether the testcases is sufficient.

[jkalias]

I think the previous structure with TestCase was much better. My suggestion with the swapped scenarios was meant to be handled in the TestCase definition, not as a separate test function.

[f-frhs]

Thanks for the comment.
Could you tell me why using TestCode is better than using TestCodeSource for this test?

[jkalias]

I find the whole new object[] a bit overkill, that's it. I guess it's more a matter of personal taste.

[f-frhs]

Thanks for the comment.

it's more a matter of personal taste.

Could you show the reason?

[jkalias]

The reason for what exactly? I prefer compile-time checks and try to avoid object as much as possible

[f-frhs]

Thanks for telling the reasons.

Done in the commit cd80cf1.
I changed the test-code as you required. I'm not sure that the revised test-code helps the reader understand at a glance that parameters are kept intact except its order.

[jkalias]

Thank you. This is not what I meant, we can augment the existing tests with a reversed line

var line = new Line2D(Point2D.Parse(p1s), Point2D.Parse(p2s));
// existing test

var reversedLine = new Line2D(Point2D.Parse(p2s), Point2D.Parse(p1s));
// distance test with reversed line

This way you keep the TestCase cases at a minimum

[f-frhs]

Thanks for showing the example closely.

It is not recommended to test 2 things in a single unit-test.
Or do you want to say that these 2 tests are equivalent because of the symmetry?

[jkalias]

It is not recommended to test 2 things in a single unit-test.

Fully agree

Or do you want to say that these 2 tests are equivalent because of the symmetry?

Basically yes

[jkalias]

I would describe this as 'Returns the length of the perpendicular line to the given point.'