fix: skip cssRules extraction for external stylesheets#1081
Open
iammola wants to merge 1 commit intomathuo:masterfrom
Open
fix: skip cssRules extraction for external stylesheets#1081iammola wants to merge 1 commit intomathuo:masterfrom
iammola wants to merge 1 commit intomathuo:masterfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c713098:
|
Owner
|
Can you explain why? |
Contributor
Author
|
Hi @mathuo, pardon! I forgot to add my explanation. I've updated the PR Description now. Please let me know what you think! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the code appends:
<link />element for each external stylesheet, and<style />element for each extracted CSS rule from both internal and external stylesheetsThese are the issues I am currently affected with:
<style />elements all through CSP errors in the console when thestyle-srcdoesn't allowunsafe-inlineAlso, it may be good to check if an element with that
hrefalready exists before appending the new<link />.In my case, my app is built with Vite, so the only CSS file loaded is already in the document. I noticed this duplication when using the Popout feature.