feat: add header position support to dockview group panel#941
feat: add header position support to dockview group panel#941mslxl wants to merge 5 commits intomathuo:masterfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 30ccca0:
|
|
Nice! Cant wait for it to merge |
|
@mslxl - this is awesome! I would agree with what @SeanBannister is saying regarding the position of the "close" button.
|
|
This would be really nice to have as soon as possible. We are in the process of selecting a dock manager and Dockview it the favorite so far. The only thing that makes us doubt is the position of the tabs. For reference, Visual Studio has the text as in this screen shot. But using a wide screen makes it unnatural to turn the head to the right, so I agree with @SeanBannister that the orientation should be changed if the tabs are placed to the left. |
|
Thanks for the appreciation Regarding text orientation, I don't think it should be modified. Allowing users to customize the component might be the simpler choice. This is mainly based on two considerations. First is the typography of CJK characters (and perhaps other languages I'm not familiar with). In some contexts, their vertical layout should not be rotated, and The second is the implementation issue. The current Additionally, this PR has been open for too long, and I've already forgotten some of the context. When this PR was created, it was arguably the "pre-AI coding era." Now that various Agents and models have taken the world stage, the significance of this PR's existence has become questionable. |




Resolve #894
Add
headerPositionoption to DockviewGroupPanel so that the user can change the position of the tab container in Dockview.I have added a new action to
packages\docs\sandboxes\react\dockview\demo-dockview, which allows the position field to loop through 'top', 'left', 'bottom', and 'right'.Tested on firefox and chrome