-
Notifications
You must be signed in to change notification settings - Fork 86
Rework oidc provider construction #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
3c155a6 to
fce2e5a
Compare
|
Sorry i may have been a bit harsh with the words. I was still in my Software Engineering mindset and honestly a little frustrated since it took me some time to get this software to compile properly. (I will probably open an issue or a PR for the problems i encountered) I refactored a lot of the configuration code, in my opinion this should be way better to read and maintain. If you have any questions about the code please don't hesitate to ask |
fce2e5a to
f0a3df6
Compare
f0a3df6 to
03e6637
Compare
|
Not sure why the CI fails on unchanged code. Runs fine on main: https://github.com/matrix-construct/tuwunel/actions/runs/21559255457/job/62120577532 |
|
I think this is some new issue with the typos tool we use for detecting typos, not the first time something like this has happened. We will handle it ourselves don't worry. Thank you for the contribution. |
|
@Jeidnx If possible, pls add username claim from OAuth provider. |
03e6637 to
f0a3e96
Compare
Signed-off-by: Jason Volk <jason@zemos.net>
Fixes the issue where discovery urls where assembled incorrectly. Also removes the default values for unbranded providers, since there is no sane default that can be provided.
f0a3e96 to
a7731f6
Compare
|
When testing GitHub I 404'ed after the initial redirect. At a glance it might be that the base_path is not being applied. I can have a look but I have to merge the other pending items to main branch first. |
Rework the initialization code for oidc providers: