Conversation
Previously we always relied on the HS under test creating v12 rooms, and Complement could only join/send into those rooms. This is a problem if we want to build room versions on top of v12 rooms, as we need Complement to be able to create v12 rooms too.
devonh
requested changes
Jan 28, 2026
Contributor
devonh
left a comment
devonh
left a comment
There was a problem hiding this comment.
Overall this looks good. Just a couple comments.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we always relied on the HS under test creating v12 rooms,
and Complement could only join/send into those rooms. This is a problem
if we want to build room versions on top of v12 rooms, as we need
Complement to be able to create v12 rooms too.