Fix docker build and set MSRV to 1.78 #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openssl was failing to compile in the Dockerfile. Updating deps solved it
So that this can be caught in future.
1.78.0 is the first version of cargo that supports lock version v4 (the version of our Cargo.lock file).
MadLittleMods
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opensslwas failing to compile in the Dockerfile. Updating the dependencies solved it.This PR also updates the
docker.yamlworkflow to run on all PRs (but only push on release/main branch). This means CI will fail if the docker build is broken.Rust is only updated to 1.78.0 as that's the minimum version of
cargoneeded to read ourCargo.lockfile (which is v4).I also set the MSRV programmatically via
rust-versioninCargo.toml.