If authentication failed, no steps completed#1094
Open
kroeckx wants to merge 2 commits intomatrix-org:developfrom
Open
If authentication failed, no steps completed#1094kroeckx wants to merge 2 commits intomatrix-org:developfrom
kroeckx wants to merge 2 commits intomatrix-org:developfrom
Conversation
Member
|
Please could you merge |
Signed-off-by: Kurt Roeckx <kurt@roeckx.be>
Contributor
Author
|
It seems Synapse claims |
Signed-off-by: Kurt Roeckx <kurt@roeckx.be>
richvdh
requested changes
Jul 28, 2021
Comment on lines
+53
to
+54
| exists $body->{completed} and die "Got an unexpected 'completed' key"; | ||
|
|
Member
There was a problem hiding this comment.
I'm not entirely convinced that the presence of completed should be a failure here.
I agree that completed should not be required.
Contributor
Author
There was a problem hiding this comment.
It seems the test I did against synapse was something else. It seems synapse returns: "completed":[], which makes sense.
I guess this is an other case where the specification isn't really clear.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kurt Roeckx kurt@roeckx.be