Skip to content

test: remove bvt skip flags for dtype and function tests#23657

Open
flypiggyyoyoyo wants to merge 12 commits intomatrixorigin:mainfrom
flypiggyyoyoyo:bvt1
Open

test: remove bvt skip flags for dtype and function tests#23657
flypiggyyoyoyo wants to merge 12 commits intomatrixorigin:mainfrom
flypiggyyoyoyo:bvt1

Conversation

@flypiggyyoyoyo
Copy link
Collaborator

@flypiggyyoyoyo flypiggyyoyoyo commented Feb 3, 2026

User description

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue #23658

What this PR does / why we need it:

Remove @bvt:issue tags for fixed issues:


PR Type

Tests


Description


Diagram Walkthrough

flowchart LR
  A["Test Files with @bvt:issue Tags"] -- "Remove skip annotations" --> B["Clean Test Cases"]
  B -- "Issues: #3276, #3280, #3364, #4241, #7589, #8513, #23408" --> C["Tests Ready for BVT Execution"]
Loading

File Walkthrough

Relevant files
Tests
decimal.test
Remove BVT skip tags from decimal tests                                   

test/distributed/cases/dtype/decimal.test

  • Removed @bvt:issue#3364 tags (3 occurrences) for decimal
    overflow/precision tests
  • Removed @bvt:issue#3280 tags (2 occurrences) for decimal comparison
    and update operations
  • Removed @bvt:issue#4241 tag for decimal cast modulo operation
  • Removed @bvt:issue#8513 tags (2 occurrences) for decimal division
    operations
  • Removed standalone @bvt:issue tags (5 occurrences) marking test
    boundaries
+0/-17   
numeric.sql
Remove BVT skip tags from numeric tests                                   

test/distributed/cases/dtype/numeric.sql

  • Removed @bvt:issue#3364 tags (3 occurrences) for numeric
    overflow/precision tests
  • Removed @bvt:issue#3280 tags (2 occurrences) for numeric comparison
    and update operations
  • Removed @bvt:issue#4241 tag for numeric cast modulo operation
  • Removed @bvt:issue#8513 tags (2 occurrences) for numeric division
    operations
  • Removed standalone @bvt:issue tags (5 occurrences) marking test
    boundaries
+0/-18   
int.test
Remove BVT skip tags from int tests                                           

test/distributed/cases/dtype/int.test

  • Removed @bvt:issue#3276 tags (2 occurrences) for unsigned integer
    comparison tests
  • Removed standalone @bvt:issue tags (2 occurrences) marking test
    boundaries
+0/-4     
text_blob.sql
Remove BVT skip tags from text_blob tests                               

test/distributed/cases/dtype/text_blob.sql

  • Removed @bvt:issue#7589 tag for text subquery comparison test
  • Removed standalone @bvt:issue tag marking test boundary
+0/-2     
year.sql
Remove BVT skip tags from year tests                                         

test/distributed/cases/dtype/year.sql

  • Removed @bvt:issue#23408 tags (2 occurrences) for year unique
    constraint violation test
+0/-2     
func_anyvalue.test
Remove BVT skip tags from func_anyvalue tests                       

test/distributed/cases/function/func_anyvalue.test

  • Removed @bvt:issue#3579 tag for any_value function extreme value test
  • Removed standalone @bvt:issue tag marking test boundary
+0/-2     

@qodo-code-review
Copy link

qodo-code-review bot commented Feb 3, 2026

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🟡
🎫 #3364
🔴 Fix the bug where inserting values into a decimal(29,0) primary key column (including hex
literal like 0xFFFFFFFFFFFFFE and high-precision decimal literals) incorrectly fails with
"Data truncation: Incorrect DECIMAL128 value".
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
🟢
Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

  • Update
Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@qodo-code-review
Copy link

qodo-code-review bot commented Feb 3, 2026

PR Code Suggestions ✨

No code suggestions found for the PR.

@mergify mergify bot added the queued label Feb 6, 2026
@mergify
Copy link
Contributor

mergify bot commented Feb 6, 2026

Merge Queue Status

🚫 The pull request has left the queue (rule: main) at 18f2008

This pull request spent 13 minutes 7 seconds in the queue, with no time running CI.

Reason

The pull request #23657 has been manually updated

Hint

If you want to requeue this pull request, you can post a @mergifyio requeue comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/test-ci Review effort 2/5 size/S Denotes a PR that changes [10,99] lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Implicit conversion failed from VARCHAR to INT

3 participants