Skip to content

rm bvt tag#23679

Merged
mergify[bot] merged 12 commits intomatrixorigin:mainfrom
Ariznawlll:rm_many_tag2
Feb 5, 2026
Merged

rm bvt tag#23679
mergify[bot] merged 12 commits intomatrixorigin:mainfrom
Ariznawlll:rm_many_tag2

Conversation

@Ariznawlll
Copy link
Contributor

@Ariznawlll Ariznawlll commented Feb 4, 2026

User description

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

rm bvt tag

issue #
#8890
#9034
#9447
#10043
#10126
#10164
#10703
#12748
#22363
#23464

What this PR does / why we need it:

rm bvt tag


PR Type

Tests


Description

  • Remove BVT issue tags (@bvt:issue#*) from multiple test files across distributed test cases

  • Update test result files to reflect actual query outputs and error messages instead of placeholders

  • Normalize query result formatting including column headers, metadata annotations, and visual separators

  • Replace [unknown result because it is related to issue#*] placeholders with concrete test results

  • Remove transaction test cases and clean up test file structure for improved maintainability

  • Update issue references in test annotations (e.g., #10164 to #23677)


Diagram Walkthrough

flowchart LR
  A["BVT Tags<br/>in .sql files"] -- "Remove @bvt:issue#* annotations" --> B["Clean Test Files"]
  C["Placeholder Results<br/>in .result files"] -- "Replace with actual outputs" --> D["Updated Test Results"]
  E["Test Structure"] -- "Remove obsolete test cases" --> F["Streamlined Tests"]
  B --> G["Updated Test Suite"]
  D --> G
  F --> G
Loading

File Walkthrough

Relevant files
Tests
14 files
group.result
Update query result formatting with metadata annotations 

test/distributed/cases/qexec/group.result

  • Updated query result output formatting to include column metadata
    annotations (e.g., [-5,64,0]) and visual separators (¦ and 𝄀)
  • Modified explain analyze output to display detailed query plan
    information with timing and resource metrics
  • Reformatted multi-column result sets with new delimiter-based layout
+74/-49 
clone.result
Add missing query results and remove blank lines                 

test/distributed/cases/pessimistic_transaction/clone/clone.result

  • Removed blank lines between SQL statements for more compact output
  • Added actual query result data where previously only blank lines
    existed (e.g., select * from bit01, show create table results)
  • Replaced empty result placeholders with actual table data and schema
    information
+59/-113
create_sequence.result
Update sequence column type metadata annotations                 

test/distributed/cases/sequence/create_sequence.result

  • Updated column metadata annotations for cycle and is_called fields
    from [12,4,0] to [-7,1,0]
  • Changed type information in sequence result set headers to reflect
    corrected data type metadata
+4/-50   
query_result.result
Normalize query result column header casing                           

test/distributed/cases/query_result/query_result.result

  • Changed column header casing from uppercase to lowercase (e.g.,
    Database to database, Tables_in_test to tables_in_test)
  • Added [unknown result because it is related to issue#17598]
    placeholders for certain query results
  • Updated result column names to match lowercase convention in
    result_scan() output
+14/-14 
uuid.result
Fix UUID test formatting and result ordering                         

test/distributed/cases/dtype/uuid.result

  • Added trailing spaces to desc t1 output for column alignment
  • Reformatted CREATE TABLE statement with consistent indentation and
    lowercase keywords
  • Reordered query result rows in UUID comparison test (different sort
    order for equal values)
+5/-5     
delete.result
Replace unknown result markers with actual query results 

test/distributed/cases/dml/delete/delete.result

  • Removed [unknown result because it is related to issue#9447]
    placeholders from transaction test results
  • Added actual query results with formatted output (e.g.,
    count(*)[-5,64,0] 𝄀 and count values)
  • Replaced unknown result markers with concrete test data for select
    count(*) statements
+6/-12   
show.test
Update BVT issue reference annotation                                       

test/distributed/cases/dml/show/show.test

  • Updated issue reference from #10164 to #23677 in test annotation
    comment
  • Changed BVT tag from @bvt:issue#10164 to @bvt:issue#23677
+1/-1     
transaction_enhance.result
Update transaction test results and add new test cases     

test/distributed/cases/pessimistic_transaction/transaction_enhance.result

  • Updated expected query results to reflect actual error messages and
    behavior changes
  • Removed blank lines between SQL statements for consistency
  • Added new test cases showing transaction rollback behavior with table
    drops
  • Updated error messages to show actual SQL parser errors instead of
    placeholders
+52/-8   
isolation_1.sql
Remove BVT issue tags from isolation tests                             

test/distributed/cases/pessimistic_transaction/isolation_1.sql

  • Removed @bvt:issue#10585 tags from three test sections
  • Removed @bvt:issue placeholder tags
  • Replaced placeholder tags with blank lines for cleaner formatting
+2/-6     
create_sequence.sql
Remove sequence transaction test cases and BVT tags           

test/distributed/cases/sequence/create_sequence.sql

  • Removed large block of transaction test cases (approximately 35 lines)
  • Removed @bvt:issue#8890 and @bvt:issue tags
  • Removed tests for seq_18, seq_19, and seq_20 sequence creation
    scenarios
  • Kept only the select lastval() statement at the end
+1/-34   
window.result
Update window function test result with actual error         

test/distributed/cases/window/window.result

  • Replaced [unknown result because it is related to issue#10043]
    placeholder with actual error message
  • Updated expected result for sum(d) over (partition by d order by d
    rows between 1 preceding and 1 following) query
+1/-1     
uuid.sql
Remove BVT issue tags from UUID type tests                             

test/distributed/cases/dtype/uuid.sql

  • Removed @bvt:issue#10703 tag from UUID primary key test section
  • Removed @bvt:issue placeholder tag
  • Replaced placeholder tag with blank line
+1/-2     
transaction_enhance.sql
Remove BVT issue tags from transaction tests                         

test/distributed/cases/pessimistic_transaction/transaction_enhance.sql

  • Removed @bvt:issue#10491 tag and replaced with blank line
  • Removed @bvt:issue placeholder tag and replaced with blank line
+2/-2     
group.sql
Remove BVT issue tags from group query tests                         

test/distributed/cases/qexec/group.sql

  • Removed @bvt:issue#22721 tag and replaced with blank line
  • Removed @bvt:issue placeholder tag and replaced with blank line
+2/-2     
Additional files
8 files
delete.test +0/-2     
func_math.sql +0/-2     
func_math_floor.test +0/-2     
clone.sql +0/-2     
select_for_update.sql +0/-2     
query_result.sql +0/-2     
owner.sql +0/-2     
window.sql +0/-2     

@Ariznawlll Ariznawlll requested a review from heni02 as a code owner February 4, 2026 08:23
@CLAassistant
Copy link

CLAassistant commented Feb 4, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Ariznawlll
Ariznawl@163.com


Ariznawl@163.com seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@qodo-code-review
Copy link

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🟡
🎫 #10703
🔴 Fix the internal error/panic when running INSERT INTO on a table whose primary key is of
type uuid under pessimistic transaction mode and RC isolation.
Ensure the provided reproduction SQL (create table with uuid PK + multiple inserts) runs
without crashing and behaves correctly.
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
🟢
Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status:
Detailed error output: The updated expected outputs include detailed user-visible database error strings (e.g.,
schema/table names and internal phrasing) that may expose internal system details and
should be verified against secure error-message requirements.

Referred Code
no such table transaction_enhance.atomic_table_11
select * from atomic_table_11;
SQL parser error: table "atomic_table_11" does not exist
commit;
select * from atomic_table_11;
SQL parser error: table "atomic_table_11" does not exist

Learn more about managing compliance generic rules or creating your own custom rules

Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@qodo-code-review
Copy link

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
Possible issue
Fix incorrect transaction rollback behavior

Correct the test result to reflect proper transaction rollback behavior, as the
current result shows data persisting after a rollback, which violates atomicity.

test/distributed/cases/pessimistic_transaction/transaction_enhance.result [81-97]

 begin;
 
 drop table atomic_table_11;
 insert into atomic_table_11 values (6,"a");
+no such table transaction_enhance.atomic_table_11
 select * from atomic_table_11;
-c1    c2
-3    a
-4    b
-5    c
-6    a
+SQL parser error: table "atomic_table_11" does not exist
 rollback ;
 select * from atomic_table_11;
 c1    c2
 3    a
 4    b
 5    c
-6    a
  • Apply / Chat
Suggestion importance[1-10]: 9

__

Why: The suggestion correctly identifies a critical issue where a transaction rollback fails to revert changes, violating ACID principles, which indicates a potential major bug in the database behavior.

High
  • More

@mergify mergify bot added the queued label Feb 5, 2026
@mergify
Copy link
Contributor

mergify bot commented Feb 5, 2026

Merge Queue Status

✅ The pull request has been merged at 504a31e

This pull request spent 2 hours 30 minutes 40 seconds in the queue, including 53 minutes 22 seconds running CI.
The checks were run in-place.

Required conditions to merge
  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Matrixone Compose CI / multi cn e2e bvt test docker compose(PESSIMISTIC)
    • check-neutral = Matrixone Compose CI / multi cn e2e bvt test docker compose(PESSIMISTIC)
    • check-skipped = Matrixone Compose CI / multi cn e2e bvt test docker compose(PESSIMISTIC)
  • any of [🛡 GitHub branch protection]:
    • check-success = Matrixone Standlone CI / Multi-CN e2e BVT Test on Linux/x64(LAUNCH, PROXY)
    • check-neutral = Matrixone Standlone CI / Multi-CN e2e BVT Test on Linux/x64(LAUNCH, PROXY)
    • check-skipped = Matrixone Standlone CI / Multi-CN e2e BVT Test on Linux/x64(LAUNCH, PROXY)
  • any of [🛡 GitHub branch protection]:
    • check-success = Matrixone Standlone CI / e2e BVT Test on Linux/x64(LAUNCH, PESSIMISTIC)
    • check-neutral = Matrixone Standlone CI / e2e BVT Test on Linux/x64(LAUNCH, PESSIMISTIC)
    • check-skipped = Matrixone Standlone CI / e2e BVT Test on Linux/x64(LAUNCH, PESSIMISTIC)
  • any of [🛡 GitHub branch protection]:
    • check-success = Matrixone CI / SCA Test on Ubuntu/x86
    • check-neutral = Matrixone CI / SCA Test on Ubuntu/x86
    • check-skipped = Matrixone CI / SCA Test on Ubuntu/x86
  • any of [🛡 GitHub branch protection]:
    • check-success = Matrixone CI / UT Test on Ubuntu/x86
    • check-neutral = Matrixone CI / UT Test on Ubuntu/x86
    • check-skipped = Matrixone CI / UT Test on Ubuntu/x86
  • any of [🛡 GitHub branch protection]:
    • check-success = Matrixone Compose CI / multi cn e2e bvt test docker compose(Optimistic/PUSH)
    • check-neutral = Matrixone Compose CI / multi cn e2e bvt test docker compose(Optimistic/PUSH)
    • check-skipped = Matrixone Compose CI / multi cn e2e bvt test docker compose(Optimistic/PUSH)
  • any of [🛡 GitHub branch protection]:
    • check-success = Matrixone Standlone CI / e2e BVT Test on Linux/x64(LAUNCH,Optimistic)
    • check-neutral = Matrixone Standlone CI / e2e BVT Test on Linux/x64(LAUNCH,Optimistic)
    • check-skipped = Matrixone Standlone CI / e2e BVT Test on Linux/x64(LAUNCH,Optimistic)
  • any of [🛡 GitHub branch protection]:
    • check-success = Matrixone Upgrade CI / Compatibility Test With Target on Linux/x64(LAUNCH)
    • check-neutral = Matrixone Upgrade CI / Compatibility Test With Target on Linux/x64(LAUNCH)
    • check-skipped = Matrixone Upgrade CI / Compatibility Test With Target on Linux/x64(LAUNCH)
  • any of [🛡 GitHub branch protection]:
    • check-success = Matrixone Utils CI / Coverage
    • check-neutral = Matrixone Utils CI / Coverage
    • check-skipped = Matrixone Utils CI / Coverage

@mergify mergify bot merged commit 3378398 into matrixorigin:main Feb 5, 2026
23 of 24 checks passed
@mergify mergify bot removed the queued label Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Something isn't working Review effort 3/5 size/L Denotes a PR that changes [500,999] lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants