fix: enable timely stats update to avoid large row count estimation deviation#23692
Merged
mergify[bot] merged 3 commits intomatrixorigin:mainfrom Feb 5, 2026
Merged
fix: enable timely stats update to avoid large row count estimation deviation#23692mergify[bot] merged 3 commits intomatrixorigin:mainfrom
mergify[bot] merged 3 commits intomatrixorigin:mainfrom
Conversation
gouhongshen
approved these changes
Feb 5, 2026
Contributor
Merge Queue Status✅ The pull request has been merged at ba0d66a This pull request spent 2 hours 6 minutes in the queue, including 54 minutes 41 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue #23689
What this PR does / why we need it:
After the stats refactoring, when multiple secondary indexes are created concurrently, the planner observes a smaller
Stats.OutCntbecause global stats were not updated in time on data object (block) changes. The upgrade-to-table-lock condition (Stats.OutCnt >= MaxRowLockCount) is then never reached, so the system keeps acquiring row locks and can accumulate ~100M row locks causing OOM (see issue #23689).This change treats data object logtail entries (
api.Entry_DataObject) as meta-changing inprocessLogtail, in addition to existing meta entries. When blocks/data objects change, they are counted as meta changes and can trigger stats refresh (subject to existing rate limiting inshouldEnqueueUpdate). Stats then reflect table size more timely and row count estimation deviation is reduced, so the planner can correctly upgrade to table lock and avoid excessive row locks.