change access level of MidiTime properties to public#10
Open
cpgarvey wants to merge 1 commit intomatsune:masterfrom
Open
change access level of MidiTime properties to public#10cpgarvey wants to merge 1 commit intomatsune:masterfrom
cpgarvey wants to merge 1 commit intomatsune:masterfrom
Conversation
|
I had the same issue! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@matsuneさん, this is a great project! Very well done! 🙌 Thank you, and the other contributors, for creating it.
I was having an issue with accessing the
MidiTime.inTicksproperty that I wanted to use, so I wanted to make those public. Because there was no explicit access level set on the properties inMidiTime, it was getting the defaultinternal. I didn't see much a danger in exposing them and thought maybe others might want access to those properties too, so I'm submitting a pull request for your review.Thanks again!