[GHG-654] Added mentions on sidebar buttons / rhs bar by cyrusjc · Pull Request #775 · mattermost/mattermost-plugin-github

cyrusjc · 2024-05-03T00:47:48Z

Closes #654

Summary:
Added mention icon and associated information in the RHS bar for the mentions in PRs as suggested in the issue.

Server side changes include additional mentions graphql search query.
Webapp changes includes the mentions on the github sidebar buttons + sidebar right

Changes looks like:

mattermost-build · 2024-05-03T00:47:53Z

Hello @cyrusjc,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

hanzei · 2024-05-06T08:16:18Z

webapp/src/components/sidebar_buttons/sidebar_buttons.jsx

+                        style={button}
+                    >
+                        <i className='fa fa-comment-o'/>
+                        {' ' + mentions.length}


I'm leaning towards not showing the number of mentions.

There are users who are keen on keeping their inboxes empty. Given that they have no control over this number and can't reduce it, I wonder if we should omit the number. The button would still allow the user to check in on their conversation but would no longer nag them.

That's a good point. I think it makes sense to remove the number. Would we then want to change the ordering of the mentions icon? I was thinking since it would be just an icon we can move it next to the refresh button

It would look something like this:

@hanzei Is it possible to "remove" mentions? Maybe unsubscribing to the issue/PR does this?

@cyrusjc Do you know?

It would look something like this:

I like the suggestion 👍

I don't sorry.

server/plugin/api.go

server/plugin/graphql/lhs_request.go

webapp/src/selectors.js

mickmister · 2024-05-14T21:56:56Z

@cyrusjc There are some merge conflicts to resolve due to a recent typescript PR merge. Can you please take a look at them? Thanks for your work on this!! 😄

mickmister

LGTM, nice work @cyrusjc 👍 Just one comment for discussion

webapp/src/reducers/index.ts

webapp/src/selectors.ts

mickmister

LGTM

mattermost-build · 2024-06-08T01:02:38Z

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

arush-vashishtha

This PR has been tested for the "mentions" feature in the RHS along with setting the organizational lock. LGTM

raghavaggarwal2308 · 2024-12-30T13:08:47Z

@cyrusjc Can you please resolve the conflicts on this PR?

abbas-dependable-naqvi · 2025-07-23T08:19:58Z

@cyrusjc Are you still willling to work on this PR?

cyrusjc · 2025-07-24T18:12:07Z

@cyrusjc Are you still willling to work on this PR?

Yea I'll take a look over the weekend

mattermost-build · 2025-09-01T01:07:06Z

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

…ub into cyrusjc/adding-mentions-to-sidebar

wiggin77 · 2025-10-17T20:48:36Z

/update-branch

mattermost-build · 2025-10-17T20:48:40Z

Error trying to update the PR.
Please do it manually.

server/plugin/graphql/lhs_request.go

wiggin77

See comment.

…ions-to-sidebar

nevyangelova

LGTM

wiggin77 · 2026-01-05T15:56:25Z

server/plugin/graphql/lhs_request.go

 	baseOpenPR := fmt.Sprintf("author:%s is:pr is:%s archived:false", username, githubv4.PullRequestStateOpen)
 	baseReviewPR := fmt.Sprintf("review-requested:%s is:pr is:%s archived:false", username, githubv4.PullRequestStateOpen)
 	baseAssignee := fmt.Sprintf("assignee:%s is:%s archived:false", username, githubv4.PullRequestStateOpen)
+	baseMentions := fmt.Sprintf("mentions:%s is:%s is:pr archived:false", c.username, githubv4.PullRequestStateOpen)


Shouldn't the username passed to the method be used here?

Suggested change

baseMentions := fmt.Sprintf("mentions:%s is:%s is:pr archived:false", c.username, githubv4.PullRequestStateOpen)

baseMentions := fmt.Sprintf("mentions:%s is:%s is:pr archived:false", username, githubv4.PullRequestStateOpen)

cyrusjc requested review from hanzei and mickmister as code owners May 3, 2024 00:47

mattermost-build added the Contributor label May 3, 2024

cyrusjc changed the title ~~[GHG 654] Added mentions on sidebar buttons / rhs bar~~ [GHG-654] Added mentions on sidebar buttons / rhs bar May 3, 2024

hanzei reviewed May 6, 2024

View reviewed changes

hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester 3: Security Review Review requested from Security Team and removed 3: Security Review Review requested from Security Team labels May 6, 2024

mickmister requested a review from ayusht2810 May 7, 2024 19:57

ayusht2810 reviewed May 8, 2024

View reviewed changes

server/plugin/api.go Outdated Show resolved Hide resolved

server/plugin/graphql/lhs_request.go Outdated Show resolved Hide resolved

webapp/src/selectors.js Outdated Show resolved Hide resolved

mickmister reviewed May 23, 2024

View reviewed changes

webapp/src/reducers/index.ts Outdated Show resolved Hide resolved

webapp/src/selectors.ts Outdated Show resolved Hide resolved

mickmister approved these changes May 28, 2024

View reviewed changes

mickmister requested a review from AayushChaudhary0001 May 28, 2024 19:55

mattermost-build added the Lifecycle/1:stale label Jun 8, 2024

raghavaggarwal2308 requested a review from wiggin77 July 5, 2024 08:29

arush-vashishtha approved these changes Dec 30, 2024

View reviewed changes

raghavaggarwal2308 self-requested a review December 30, 2024 13:08

wiggin77 removed their request for review January 15, 2025 19:39

cyrusjc force-pushed the cyrusjc/adding-mentions-to-sidebar branch from 64ffb6d to a1dd6ab Compare July 26, 2025 02:36

cyrusjc requested a review from wiggin77 as a code owner July 26, 2025 02:36

cyrusjc added 2 commits July 25, 2025 19:52

feat(web): ts mentions component

843f899

feat(server): added query for mentions

520b6e2

cyrusjc force-pushed the cyrusjc/adding-mentions-to-sidebar branch from a1dd6ab to 520b6e2 Compare July 26, 2025 02:53

wiggin77 removed the Lifecycle/1:stale label Aug 21, 2025

mattermost-build added the Lifecycle/1:stale label Sep 1, 2025

Merge branch 'master' of github.com:mattermost/mattermost-plugin-gith…

d6b9ff6

…ub into cyrusjc/adding-mentions-to-sidebar

abbas-dependable-naqvi requested a review from a team as a code owner October 14, 2025 11:40

fix lint

aa32b3d

wiggin77 reviewed Nov 8, 2025

View reviewed changes

server/plugin/graphql/lhs_request.go Show resolved Hide resolved

wiggin77 requested changes Nov 8, 2025

View reviewed changes

fix: add mentions cursor initialization in fetchLHSData function

7ca5253

cyrusjc requested a review from a team as a code owner December 26, 2025 05:12

cyrusjc requested a review from wiggin77 December 26, 2025 05:20

Merge remote-tracking branch 'origin/master' into cyrusjc/adding-ment…

9a42083

…ions-to-sidebar

nevyangelova approved these changes Jan 5, 2026

View reviewed changes

wiggin77 reviewed Jan 5, 2026

View reviewed changes

cyrusjc and others added 2 commits January 9, 2026 20:49

Merge branch 'mattermost:master' into cyrusjc/adding-mentions-to-sidebar

23882be

fix: correct username reference in mentions query for fetching PRs

e3faecf

	baseMentions := fmt.Sprintf("mentions:%s is:%s is:pr archived:false", c.username, githubv4.PullRequestStateOpen)
	baseMentions := fmt.Sprintf("mentions:%s is:%s is:pr archived:false", username, githubv4.PullRequestStateOpen)

Conversation

cyrusjc commented May 3, 2024

Uh oh!

mattermost-build commented May 3, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mickmister commented May 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mickmister left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mickmister left a comment

Choose a reason for hiding this comment

Uh oh!

mattermost-build commented Jun 8, 2024

Uh oh!

arush-vashishtha left a comment

Choose a reason for hiding this comment

Uh oh!

raghavaggarwal2308 commented Dec 30, 2024

Uh oh!

abbas-dependable-naqvi commented Jul 23, 2025

Uh oh!

cyrusjc commented Jul 24, 2025

Uh oh!

mattermost-build commented Sep 1, 2025

Uh oh!

wiggin77 commented Oct 17, 2025

Uh oh!

mattermost-build commented Oct 17, 2025

Uh oh!

Uh oh!

wiggin77 left a comment

Choose a reason for hiding this comment

Uh oh!

nevyangelova left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

mickmister commented May 14, 2024 •

edited

Loading