ENH: Allow arbitrary date formats#72
Open
ludaavics wants to merge 5 commits intomatthewgilbert:masterfrom
Open
ENH: Allow arbitrary date formats#72ludaavics wants to merge 5 commits intomatthewgilbert:masterfrom
ludaavics wants to merge 5 commits intomatthewgilbert:masterfrom
Conversation
Owner
|
Thanks @ludaavics, will review when I get some free time. |
Author
|
hi @matthewgilbert -- just checking if you have any issue with the pr? Thanks! |
Owner
|
@ludaavics thanks for the PR. I reviewed it but I think a big change to the public facing API (even though this should be backwards compatible) is not something I want to introduce into the library at this point. I think this type of behaviour could be supported via decorators, so that is one option for supporting the behaviour in your own applications. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When generating dates dynamically I've found it tedious to convert the objects to the required format.
test_bulkref_two_ticker_one_fieldandtest_bsrch. However, these tests currently fail in the main branch as wellgit diff upstream/master -u -- "*.py" | flake8 --diff