This repository was archived by the owner on Feb 24, 2025. It is now read-only.
feat(types): convert exports to explicit type exports#150
Open
kad-busses wants to merge 1 commit intomattrglobal:masterfrom
Open
feat(types): convert exports to explicit type exports#150kad-busses wants to merge 1 commit intomattrglobal:masterfrom
kad-busses wants to merge 1 commit intomattrglobal:masterfrom
Conversation
|
Running into the same problem. I am doing this manually. Would love for this to be added to the npm package :) |
|
Hi team, we are experiencing the same issue. Just wonder why this PR has been open for a year without approval? 😅 |
Hey. If you need, I created a fork with this fixed at |
nickz-t3
approved these changes
Jun 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Types cannot be re-exported when using the --isolatedModules TypeScript compiler flag. For some transpilers (Babel for example) this flag is mandatory, making it impossible to add this package.
TypeScript has a Type-Only Imports and Export feature, which addresses this issue. This PR converts the type exports to explicit types.
Closes #69
Does this PR introduce a breaking change?
Which merge strategy will you use?