Fix parameter coerce when Hash or Array expected.#54
Open
serargz wants to merge 1 commit intomattt:masterfrom
Open
Fix parameter coerce when Hash or Array expected.#54serargz wants to merge 1 commit intomattt:masterfrom
serargz wants to merge 1 commit intomattt:masterfrom
Conversation
When Array is expected and for some reason a Hash is received, an unhandled exception was raised. The same thing happens when Hash is expected an Array is received. This commit converts the Hash to Array with Array#to_a for the first case, and converts the Array to string for the former.
Author
|
hi @mattt, any plans to merge this PR? |
Owner
|
Apologies for the delay in responding, @serargz. Thank you for your contribution. I think there's a lot of room for improvement in the current implementation. The clever Ruby idioms I used in the initial implementation aren't looking too great now with all of this additional functionality. I'm investigating a refactoring for all this in the next major release, and will look into how best to incorporate your changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Array is expected and for some reason a Hash is received, an
unhandled exception was raised. The same thing happens when Hash is
expected an Array is received. This commit converts the Hash to Array
with Array#to_a for the first case, and converts the Array to string for
the former.