Fix bridging video attachments from matrix clients that didn't include an extension#123
Open
ownaginatious wants to merge 1 commit intomautrix:masterfrom
Open
Fix bridging video attachments from matrix clients that didn't include an extension#123ownaginatious wants to merge 1 commit intomautrix:masterfrom
ownaginatious wants to merge 1 commit intomautrix:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm running
mautrix-imessagelocally and noticed that when I send a video attachment from the Element iOS client, the video attachment arrives as an unknown file in the Messages app:It would appear this is happening because the file is simply called
Videowithout an extension. You would think the mime type would be enough to infer that, but I guess not ¯\_ (ツ)_/¯This PR fixes it by adding the (probable) extension based on the mime type to correct the issue.