Support for Sending & Displaying Rich Links from BlueBubbles#210
Draft
joshuafhiggins wants to merge 17 commits intomautrix:masterfrom
Draft
Support for Sending & Displaying Rich Links from BlueBubbles#210joshuafhiggins wants to merge 17 commits intomautrix:masterfrom
joshuafhiggins wants to merge 17 commits intomautrix:masterfrom
Conversation
still trying to implement recieving
save the last message for the end
joshuafhiggins
requested review from
cnuss,
trek-boldly-go and
tulir
as code owners
trek-boldly-go
approved these changes
Apr 22, 2024
dltacube
approved these changes
Apr 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #183
Adds support for sending messages with rich link data, by setting a flag that BlueBubbles forwards with the private-api for iMessage to scan the text for a link to include rich link data with. When receiving a message from BB with rich link data, the payloadData field in a message's JSON is filled out, but this JSON is hard to structure and parse (coming straight from the iMessage DB). The BB app parses this on the client in Dart in order to make it usable, see payload_data.dart. Instead, I opted to use a library to fetch the OpenGraph metadata for the link sent, as how iMessage would, and fill out the struct that way. Images that BB sends as attachments are still used for the rich link.